Iterate on badge / unread indicator color (#5332) #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
force-pushed
the
feature/bma/fix_color
branch
from
5847f7b to
b867e5f
Compare
ouchadam
reviewed
Mar 8, 2022
| <item name="vctr_header_background">?vctr_system</item> | ||
| <item name="vctr_list_separator">?vctr_content_quinary</item> | ||
| <item name="vctr_list_separator_system">?vctr_system</item> | ||
| <item name="vctr_list_separator_on_surface">?vctr_system</item> | ||
| <item name="vctr_unread_background">?vctr_content_tertiary</item> |
There was a problem hiding this comment.
👍 for the alias, also allows light/dark to use separate theme values if needed
ouchadam
approved these changes
Mar 8, 2022
|
thanks for the screenshots, looks better/easier to read to my developer eyes 👀 will leave final sign off to @amshakal |
amshakal
approved these changes
Mar 8, 2022
|
Hey, I came here because of the lack of contrast on the dark theme unread badge before this PR, but according to what I see on the "after" screenshot it seems it's still far from an easy-to-read badge (contrary to the light theme's one). Don't you think ? Have you tested the colors on some WCAG check tool? Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5332 .
Before
After