Fix missing messages when forward paging with chunks > 50 messages

[SpiritCroc]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• offsets() was not limiting in the right direction when loading
  messages forwards
• after fixing offsets(), more recent messages would not be loaded due
  to the isLastForward() check, so better prioritize the SUCCESS
  LoadMoreResult over the REACHED_END here

Motivation and context

Fixes #5448

Tests

1. Permalink the latest message in a room
2. Go back to room list
3. Receive lots of new messages in that room (e.g. 100)
4. Open the room from the permalink
5. Check if all messages are shown

Tested devices

• Physical
• Emulator
• OS version(s): Android 11

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

Signed-off-by: Tobias Büttner [email protected]

[bmarty]

Thanks for your PR.
LGTM, but I do not see your sign off. Can you add a comment to the PR please? (this is why I request change here)

Also @ganfra can you have a second check on the changes please?

[SpiritCroc]

Thanks for your PR. LGTM, but I do not see your sign off. Can you add a comment to the PR please? (this is why I request change here)

It's in the last line of the PR message, should I move it?

[ganfra]

Good catch, thanks!

[bmarty]

Thanks for your PR. LGTM, but I do not see your sign off. Can you add a comment to the PR please? (this is why I request change here)

It's in the last line of the PR message, should I move it?

Ah no, that's fine, sorry I was blind!