Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Media cache size with negative values in the General Settings screen #5396

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

tgloureiro
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix #5394
Negative media cache sizes due to Int overflow.

Signed-off-by: Tiago Loureiro [email protected]

Motivation and context

Screenshots / GIFs

Tested devices

  • Physical
  • Emulator

Checklist

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Mar 1, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@bmarty bmarty merged commit d4caad1 into element-hq:develop Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media cache size with negative values in the General Settings screen
2 participants