Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTUE - Personalisation complete #5389

Merged
merged 9 commits into from
Mar 15, 2022
Merged

FTUE - Personalisation complete #5389

merged 9 commits into from
Mar 15, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Mar 1, 2022 •
edited
Loading

Type of change

  • WIP Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Introduces the confetti effect on the Account created screen when personalisation isn't supported
  • When personalisation is supported, an extra personalisation complete screen is added with confetti affect
  • Also tweaks some of styling for dark mode
    • Makes the Profile picture toolbar transparent
    • Updates the confetti colour to match the design palette
    • Splits the onboarding icons foreground from background and tints the foreground to white for light and dark mode

Motivation and context

Part of #5200

To celebrate the account creation/personalisation

Screenshots / GIFs

PERSONALISATION NOT SUPPORTED PERSONALISATION SUPPORTED DARK MODE
after-no-per-confetti after-per-complete Screenshot_20220304_132114

Styling tweaks

BEFORE AFTER
before-picture after picture
before-display Screenshot_20220307_125951
before-confetti after confetti

Tests

  • With personalisation feature flag enable
  • Override homeserver capabilities via private settings
  • Create account

Tested devices

  • Physical
  • Emulator
  • OS version(s): Pixel 5 - 29

@ouchadam ouchadam added the Z-FTUE Issue is relevant to the first time use project or experience label Mar 1, 2022
@ouchadam ouchadam mentioned this pull request Mar 1, 2022
Closed
10 tasks
@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

Unit Test Results

  98 files  ±0    98 suites  ±0   1m 18s ⏱️ -1s
180 tests +1  180 ✔️ +1  0 💤 ±0  0 ❌ ±0 
590 runs  +2  590 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 9d49ef5. ± Comparison against base commit 1a76914.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    =passed=6 failures=17 errors=0 skipped=2
  • [org.matrix.android.sdk.account]
    =passed=2 failures=1 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    =passed=107 failures=13 errors=0 skipped=38
  • [org.matrix.android.sdk.ordering]
    =passed=0 failures=1 errors=0 skipped=0
  • [org.matrix.android.sdk.PermalinkParserTest]
    =passed=2 failures=0 errors=0 skipped=0

@ouchadam ouchadam mentioned this pull request Mar 2, 2022
Merged
6 tasks
@ouchadam ouchadam force-pushed the feature/adm/personalisation-complete branch from ff35d39 to 0225565 Compare March 7, 2022 10:04
@ouchadam ouchadam force-pushed the feature/adm/display-personalisation-based-on-capabilities branch from c3c193d to 147de6e Compare March 7, 2022 16:43
@ouchadam ouchadam changed the base branch from feature/adm/display-personalisation-based-on-capabilities to feature/adm/tmp-base March 7, 2022 16:58
@ouchadam ouchadam force-pushed the feature/adm/personalisation-complete branch from ae20e58 to 6ded764 Compare March 7, 2022 17:17
@ouchadam ouchadam changed the base branch from feature/adm/tmp-base to feature/adm/display-personalisation-based-on-capabilities March 7, 2022 17:17
@ouchadam ouchadam force-pushed the feature/adm/display-personalisation-based-on-capabilities branch from 21222c1 to c06d3ff Compare March 14, 2022 12:58
Base automatically changed from feature/adm/display-personalisation-based-on-capabilities to develop March 14, 2022 13:34
ouchadam added 8 commits March 15, 2022 13:07
@ouchadam
playing confetti effect when unable to personalise account on account…
9f6d3ec 
… creation

- extracts the logic to an extension for reuse from the timeline
@ouchadam
adding personalization complete screen
e3c3db2
@ouchadam
adding changelog entry
9c114f3
@ouchadam
removing unneeded button background colour
9575cb5 
- causes the rounded corners and highlight to stop working
@ouchadam
updating all confetti usages to use design palette colours
8d0435d
@ouchadam
making the profile screen toolbar transparent, matches the designs fo…
049ae4a 
…r dark mode
@ouchadam
replacing the ftue icons with only the foreground asset to allow for …
161cd3f 
…tinting

- making use of the generic circle shape the background, this allows the foreground and background layers to be tintable separately
@ouchadam
removing unused import
1c63789
@ouchadam ouchadam force-pushed the feature/adm/personalisation-complete branch from 6ded764 to 1c63789 Compare March 15, 2022 13:12
@ouchadam ouchadam marked this pull request as ready for review March 15, 2022 13:13
@ouchadam ouchadam requested review from a team and ericdecanini and removed request for a team March 15, 2022 13:13
ericdecanini
ericdecanini suggested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@ericdecanini ericdecanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Just some lint errors to fix but the code LGTM

@ouchadam
Copy link
Contributor Author

argh the rebase got me, will fix!

@ouchadam ouchadam merged commit 17d363c into develop Mar 15, 2022
@ouchadam ouchadam deleted the feature/adm/personalisation-complete branch March 15, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdecanini ericdecanini ericdecanini approved these changes

Assignees
No one assigned
Labels
Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouchadam @ericdecanini