Add padding before first own message

[p1gp1g]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Add a padding before the first message send by ourselves. It is the same size than a displayed name.

Motivation and context

It is easier to view our messages from others if the padding is a bit bigger.

Screenshots / GIFs

Before	After

Edit: adding a table for better comparison of screnshoots

Tested devices

• Physical
• Emulator
• OS version(s): 9

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[bmarty]

This looks good to me, thanks for the PR!
I ask for a design review from @amshakal
Also can you add a small file for the changelog? You can see instruction here

Thanks!

[amshakal]

Hi there! Thanks for working on this. :) I agree with your solution. Before I approve, just want to check what's the padding (in pixels, if possible) you are using here?

[p1gp1g]

I'll do the variable rename & changelog file (.misc ?) when I've free time.

Hi there! Thanks for working on this. :) I agree with your solution. Before I approve, just want to check what's the padding (in pixels, if possible) you are using here?

To have the same padding than the one before the bubble from other senders, I did an empty name instead of an explicit padding. That way, if you want to edit the name size, it will change that padding too.

[bmarty]

Thanks for the update!
I approve the PR, but @amshakal needs to approve it to so that we can merge it.

[ganfra]

Be aware it will increase "blank" space if you have some decoration between the last from other and first from you like day separator or read receipts.

[p1gp1g]

Be aware it will increase "blank" space if you have some decoration between the last from other and first from you like day separator or read receipts.

Indeed, here are some screenshots to illustrate :

• Before, the space before our first message is the same than the space between 2 messages of the same sender. It might be preferred to save space since there is already some space between bubbles.
• After, the space before our first message is the same than before the first from someone else. It might be preferred to have the same padding every time it is a new sender. (I think it is easier to understand) *

Before	After

---

* Comparison between same padding with reaction before/after
before :

2 from the same sender	Our first message

after :

Other's first message	Our first message

[amshakal]

Nice! Since there is no measurement to compare it to, I'll request reducing the padding just a bit (around 35%) for the reasons @ganfra stated above. Happy to approve it after that :)

[p1gp1g]

It is indeed better with a smaller padding. I've a bit edited how it works to use a 12dp space instead of the empty name.

[bmarty]

Thanks for the update. This PR will be merged if the CI is happy!

[bmarty]

Nit: it should be better to avoid using a negation here. So I would prefer to see

holder.additionalTopSpace.isVisible = attributes.informationData.messageLayout.addTopMargin

isGone -> isVisible and remove the !

Anyway, this is not a blocker.

[bmarty]

Ah, I will need a sign off to be able to merge this PR.

@p1gp1g can you add a comment to this PR with your sign off please?

[bmarty]

(waiting for sign off)

[p1gp1g]

I have removed the double negation and signed-off the commit

[bmarty]

Perfect! Thanks!