Improve usage of realm #5297
Improve usage of realm #5297
Conversation
Matrix SDKIntegration Tests Results:
|
| if (bgRealm.isInTransaction) { | ||
| bgRealm.cancelTransaction() | ||
| } | ||
| return withContext(Realm.WRITE_EXECUTOR.asCoroutineDispatcher()) { |
There was a problem hiding this comment.
is it worth holding onto the Realm.WRITE_EXECUTOR.asCoroutineDispatcher() instance?
There was a problem hiding this comment.
I don't think so, at least realm is not doing that neither
| @@ -90,8 +90,7 @@ internal class TimelineChunk(private val chunkEntity: ChunkEntity, | |||
| private val timelineEventsChangeListener = | |||
| OrderedRealmCollectionChangeListener { results: RealmResults<TimelineEventEntity>, changeSet: OrderedCollectionChangeSet -> | |||
| Timber.v("on timeline events chunk update") | |||
| val frozenResults = results.freeze() | |||
There was a problem hiding this comment.
This is the main fix ^ =P
| .mapNotNull { | ||
| val roomMember = RoomMemberSummaryEntity.where(readReceiptsSummaryEntity.realm, roomId = it.roomId, userId = it.userId).findFirst() | ||
| ?: return@mapNotNull null | ||
| ReadReceipt(roomMember.asDomain(), it.originServerTs.toLong()) |
There was a problem hiding this comment.
are there any side effects from switching User to RoomMember?
There was a problem hiding this comment.
User avatar can be set per room, so maybe there will be a visible effect.
There was a problem hiding this comment.
No this should just fix some cases where user has changed avatar/name only in the room
|
testing locally, I didn't see much change in realm allocations unfortunately (although that wasn't the goal of this PR so it's expected) |
That's sad, we will have to continue digging on that point |
bmarty
added
the
Z-NextRelease
Type of change
Content
This PR removes usage of frozen RealmResults in the timeline, as it wasn't necessary (not switch of threads)
Also uses Realm.WRITE_EXECUTOR for awaitTransaction.
Last, not really related to realm but took the opportunity to replace ReadReceipt.User by ReadReceipt.RoomMember as we are in a room.
Motivation and context
Improves performance of realm, and reduce the consumption of disk space (before compacting) and probably ram usage.
Tests
Tested devices