#4643: Home screen: replacing the search icon by a filter icon in the menu

[mnaturel]

Type of change

• Feature
• Bugfix
• Technical
• Other : Enhancement

Content

Replacing the search icon in the home menu by a filter icon to be more consistent.

Motivation and context

See #4643

Screenshots / GIFs

Tests

• Go to home screen
• Check a filter icon is displayed in the top right menu
• Click on the filter icon
• Check the filter screen is opened

Tested devices

• Physical
• Emulator
• OS version(s): Android 11

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[github-actions]

Unit Test Results

  76 files  ±0    76 suites  ±0   57s ⏱️ -1s
144 tests ±0  144 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
452 runs  ±0  452 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b346a73. ± Comparison against base commit 343b8bf.

[bmarty]

Looks like we are reverting what have been done for #1384. The filter icon was not clear for the users.

Happy to accept the change, but I want to be sure that @daniellekirkwood has seen #1384

[mnaturel]

Looks like we are reverting what have been done for #1384. The filter icon was not clear for the users.

Happy to accept the change, but I want to be sure that @daniellekirkwood has seen #1384

Okay no problem. I have kept my work of moving the filter bar in the lists if needed.

[github-actions]

Matrix SDK

Integration Tests Results:

• [org.matrix.android.sdk.session]
  passed="25" failures="17" errors="0" skipped="2"
• [org.matrix.android.sdk.account]
  passed="5" failures="0" errors="0" skipped="2"
• [org.matrix.android.sdk.internal]
  passed="158" failures="1" errors="0" skipped="38"
• [org.matrix.android.sdk.ordering]
  passed="16" failures="0" errors="0" skipped="0"
• [org.matrix.android.sdk.PermalinkParserTest]
  passed="2" failures="0" errors="0" skipped="0"

[daniellekirkwood]

Have seen the comments and the previous discussion. Let's stay accurate (filter icon) and implement a search feature as soon as we can