#2782: Collapse server ACLs update events #5249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
bmarty
approved these changes
Feb 17, 2022
| @@ -82,7 +83,7 @@ class MergedHeaderItemFactory @Inject constructor(private val activeSessionHolde | |||
| event: TimelineEvent, | |||
| eventIdToHighlight: String?, | |||
| requestModelBuild: () -> Unit, | |||
| callback: TimelineEventController.Callback?): MergedMembershipEventsItem_? { | |||
| callback: TimelineEventController.Callback?): DefaultMergedEventsItem_? { | |||
There was a problem hiding this comment.
OK for the renaming, but maybe something like SimilarEventsMergedItem would be more appropriate. Default prefix is reserved for default implementation of interfaces.
There was a problem hiding this comment.
Okay, I renamed the class to MergedSimilarEventsItem to be consistent with existing MergedRoomCreationItem. Is that okay?
...in/java/im/vector/app/features/home/room/detail/timeline/helper/TimelineDisplayableEvents.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Merge of multiple successive received server ACLs updates in a room into a single collapsable/expandable item.
Motivation and context
See #2782
Screenshots / GIFs
Tests
Tested devices
Checklist