Rooms with virtual rooms do not render the merged timeline with call events. #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
bmarty
reviewed
Feb 14, 2022
| @@ -54,8 +54,7 @@ internal class RoomAccountDataDataSource @Inject constructor(@SessionDatabase pr | |||
| */ | |||
| fun getAccountDataEvents(roomId: String?, types: Set<String>): List<RoomAccountDataEvent> { | |||
| return realmSessionProvider.withRealm { realm -> | |||
| val roomEntity = buildRoomQuery(realm, roomId, types).findFirst() ?: return@withRealm emptyList() | |||
| roomEntity.accountDataEvents(types) | |||
| buildRoomQuery(realm, roomId, types).findAll().flatMap { it.accountDataEvents(types) } | |||
There was a problem hiding this comment.
FTR the fun getAccountDataEvents was not used, so we did no see the bug before. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates getAccountDataEvents function to match its description.
Fixes #5198