Retrieve map style url from .well-known #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
ouchadam
reviewed
Feb 7, 2022
| val mapUrl = buildString { | ||
| append(MAP_BASE_URL) | ||
| append(keyParam) | ||
| suspend fun getMapUrl(): String { |
There was a problem hiding this comment.
small nit: this might be easier to parse if we separate the fallback with its own variable
private val fallbackMapUrl = buildString {
append(MAP_BASE_URL)
append(keyParam)
}
suspend fun getMapUrl(): String {
val upstreamMapUrl = tryOrNull { rawService.getElementWellknown(session.sessionParams) }
?.mapTileServerConfig
?.mapStyleUrl
return upstreamMapUrl ?: fallbackMapUrl
}what do you think?
There was a problem hiding this comment.
Much easier to read! I will commit, thanks.
bmarty
reviewed
Feb 14, 2022
| ?.mapStyleUrl | ||
| return upstreamMapUrl ?: fallbackMapUrl | ||
| } | ||
|
|
||
| fun buildStaticMapUrl(locationData: LocationData, |
There was a problem hiding this comment.
I think this fun should also be impacted by the url set up in the .well-known file, since AFAIU, it can contain another API key.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5175.
MSC