Sync analytics plan #5171
Merged
Sync analytics plan #5171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Identity replaced with UserProperty added missing param for JoinedRoom
# Conflicts: # vector/src/main/java/im/vector/app/features/analytics/impl/DefaultVectorAnalytics.kt # vector/src/main/java/im/vector/app/features/analytics/plan/Composer.kt # vector/src/main/java/im/vector/app/features/onboarding/OnboardingViewModel.kt
ouchadam
approved these changes
Feb 9, 2022
|
LGTM! once the CI is happy |
Matrix SDKIntegration Tests Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update analytics plan
Reviewers:
Note: Change are coming from this project