Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing ignored font weights #5135

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Fixing ignored font weights #5135

merged 2 commits into from
Feb 2, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Feb 2, 2022

Fixes #3907 Ignored font weights

We're setting a global typeface in our application theme which is overriding our manually set fontFamily styles

BEFORE AFTER
before-font-weights after-without-font-limit

@ouchadam ouchadam added the X-Needs-Design May require input from the design team label Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Unit Test Results

  76 files  ±0    76 suites  ±0   1m 3s ⏱️ +3s
143 tests ±0  143 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
448 runs  ±0  448 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 96efeae. ± Comparison against base commit 2ffc89d.

bmarty
bmarty approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos!

@bmarty bmarty merged commit 35c77c1 into develop Feb 2, 2022
@bmarty bmarty deleted the feature/adm/missing-medium-weight-fonts branch February 2, 2022 17:41
@ouchadam ouchadam mentioned this pull request Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
X-Needs-Design May require input from the design team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Textviews with a medium style don't apply sans-serif-medium font
2 participants
@ouchadam @bmarty