Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Invite users to space" dialog now closed when user choose invite method #5126

Merged
merged 1 commit into from
Feb 2, 2022
Merged

"Invite users to space" dialog now closed when user choose invite method #5126

merged 1 commit into from
Feb 2, 2022

Conversation

fedrunov
Copy link
Contributor

@fedrunov fedrunov commented Feb 2, 2022

fixes #4295

output

bmarty
bmarty approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Unit Test Results

  76 files    76 suites   59s ⏱️
143 tests 143 ✔️ 0 💤 0 ❌
448 runs  448 ✔️ 0 💤 0 ❌

Results for commit 05e209d.

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

@fedrunov fedrunov merged commit 65fd548 into develop Feb 2, 2022
@fedrunov fedrunov deleted the feature/nfe/close_space_invite_dialog branch February 2, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invite to space workflow is not logical
2 participants
@fedrunov @bmarty