Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/CD errors after merges #5119

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

ariskotsomitopoulos
Copy link
Contributor

This PR will fix some errors after merging branches to develop or master. Closes #5118

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Unit Test Results

  76 files  ±0    76 suites  ±0   1m 8s ⏱️ +13s
143 tests ±0  143 ✔️ ±0  0 💤 ±0  0 ±0 
448 runs  ±0  448 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8e90864. ± Comparison against base commit 57f3b13.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -54,15 +54,15 @@ jobs:
echo "::set-output name=body::$body"
fi
- name: Find Comment
if: always()
if: always() && github.event_name == 'pull_request'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still a bit confused about this always() thing. If there are other conditions is it still mandatory to have it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes while it means that this step will be executed even if another step fails

@bmarty bmarty merged commit 0391684 into develop Feb 1, 2022
@bmarty bmarty deleted the feature/aris/fix_github_action_merging_error branch February 1, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub actions errors after merges
2 participants