Timeline : fix 4959 #4966
Closed
Timeline : fix 4959 #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Jan 17, 2022
| (position until position + count).forEach { | ||
| // Invalidate cache | ||
| modelCache[it] = null | ||
| } | ||
| // Also invalidate the first previous displayable event if | ||
| // it's sent by the same user so we are sure we have up to date information. | ||
| val invalidatedSenderId: String? = currentSnapshot.getOrNull(position)?.senderInfo?.userId | ||
| val prevDisplayableEventIndex = currentSnapshot.subList(0, position).indexOfLast { | ||
| // In some cases onChanged will be called before onRemoved and onInserted so position will be smaller than currentSnapshot.size. |
There was a problem hiding this comment.
Suggested change
| // In some cases onChanged will be called before onRemoved and onInserted so position will be smaller than currentSnapshot.size. | |
| // In some cases onChanged will be called before onRemoved and onInserted so position will be bigger than currentSnapshot.size. |
I think, no?
Matrix SDKIntegration Tests Results:
|
bmarty
reviewed
Jan 18, 2022
| timelineEventVisibilityHelper.shouldShowEvent(it, partialState.highlightedEventId) | ||
| } | ||
| if (prevDisplayableEventIndex != -1 && currentSnapshot[prevDisplayableEventIndex].senderInfo.userId == invalidatedSenderId) { | ||
| if (prevDisplayableEventIndex != -1 && currentSnapshot.getOrNull(prevDisplayableEventIndex)?.senderInfo?.userId == invalidatedSenderId) { |
There was a problem hiding this comment.
I do not think this change is necessary, since prevDisplayableEventIndex will always be in the range [0, currentSnapshot.size[.
Anyway, better safe than sorry I guess.
37 tasks
|
Included in hotfix #4971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4959 and add more logs.