Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable automatic opt-in screen display." #4892

Merged
merged 5 commits into from
Jan 10, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 10, 2022

Enable automatic display of opt-in screen.

This reverts commit 08def81.

Also update the test so that it handles the new opt-in screen and the new FTUE flow.

Fixes #4875

@bmarty bmarty marked this pull request as draft January 10, 2022 12:50
@github-actions
Copy link

github-actions bot commented Jan 10, 2022

Ktlint Results

👍 ✅ 👍

@github-actions
Copy link

github-actions bot commented Jan 10, 2022

Unit Test Results

  66 files  ±0    66 suites  ±0   54s ⏱️ -1s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5d70aa9. ± Comparison against base commit 32f2e7d.

♻️ This comment has been updated with latest results.

@bmarty
Copy link
Member Author

bmarty commented Jan 10, 2022

image

@bmarty bmarty requested a review from ouchadam January 10, 2022 13:35
@bmarty bmarty marked this pull request as ready for review January 10, 2022 13:35
import im.vector.app.espresso.tools.waitUntilViewVisible
import im.vector.app.features.analytics.ui.consent.AnalyticsOptInActivity

class AnalyticsRobot {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bmarty bmarty enabled auto-merge January 10, 2022 13:43
@bmarty bmarty disabled auto-merge January 10, 2022 14:03
@bmarty bmarty merged commit f368ec1 into develop Jan 10, 2022
@bmarty bmarty deleted the feature/bma/analytics_opt_in branch January 10, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Analytics opt-in
2 participants