Emojis in code blocks crash #4795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tentatively fixes IllegalArgumentException when recycling the text views due to AppCompatTextView.consumeTextFutureAndSetBlocking attempting to consuming any futures, even if they may be invalid
…tempt to enforce correct setText usage
ouchadam
commented
Dec 22, 2021
|
|
||
| @EpoxyAttribute | ||
| var editedSpan: CharSequence? = null | ||
|
|
||
| override fun bind(holder: Holder) { | ||
| super.bind(holder) | ||
| holder.messageView.text = message | ||
| holder.messageView.setVectorText(message) |
There was a problem hiding this comment.
this is the fix for the crash in the code blocks (applying the same emoji fix we're using for the other message types)
ouchadam
commented
Dec 22, 2021
| @@ -24,20 +24,22 @@ import im.vector.app.EmojiSpanify | |||
| import im.vector.app.features.home.room.detail.timeline.item.BindingOptions | |||
| import javax.inject.Inject | |||
|
|
|||
| class SpanUtils @Inject constructor( | |||
| data class VectorCharSequence(val value: CharSequence, val bindingOptions: BindingOptions) | |||
There was a problem hiding this comment.
we could potentially override the hashcode/equals here to avoid epoxy throwing when spannables mutate but I chose to leave out the change from this PR to setup the groundwork instead
|
Probably have to be updated now that #4837 has been merged |
ouchadam
force-pushed
the
feature/adm/emoji-recycling
branch
from
b5ce8dc to
6380ee9
Compare
|
going to close this PR, we're only using text futures in the message item and #4837 fixes the crash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4790, Fixes #4794 Room crash when viewing/submitting emojis in code blocks (requires markdown to be enabled)
VectorCharSequenceto contain the binding options and remove duplication when applying thesetTextlogic