Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Android 8.1.1 / 27 and below emoji crash #4770

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Dec 20, 2021

Fixes #4769 emojis still crashing on android 8.1.1 and below

From the user rageshake reports we can still see emoji crashes in 1.3.11, the original fix #4698 is still valid, we were however bypassing it for android versions 8.1.1 android below

*an 8.1.1 emulator with google play services

BEFORE AFTER
Screenshot_1639994544 Screenshot_1639994587

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results

  66 files  ±0    66 suites  ±0   54s ⏱️ +4s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 18df540. ± Comparison against base commit c6a118f.

@ganfra ganfra merged commit 721bf4f into develop Dec 20, 2021
@ganfra ganfra deleted the feature/adm/emoji-27-and-below-crash branch December 20, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emojis still crashing on Android versions below 9.0 / P / API 28
2 participants