Threads P0 Release #4746

ariskotsomitopoulos · 2021-12-17T06:30:55Z

Local Threads implementation for P0 release

- Create new thread & reply to thread

** Important while this feature depends on local echo, should be added local echo support in threads to work 100%

- Renamed RoomDetailFragment to TimelineFragment while it should be reused from threads - View root thread message in room functionality

Add user friendly message thread summary on the SDK side Fix not encrypted rooms thread summaries

UI Improvements on threads summary Add View In Room bottom sheet action from within thread timeline root message

Add thread creation from photos, files, images, audios, replies etc Add slide animation to view threads from thread list Add click listener on room summary to handle cases like ( there is an image and the user upon click should view the image instead of navigating to the thread, so he can click the thread summary )

Add animation to fragment transition with offset for recyclerview initialization Support threads on deleted events

…hunk - Local notification mentioning system - Fix/Improve thread list filtering

# Conflicts: # library/ui-styles/src/main/res/values/dimens.xml # matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/events/model/RelationType.kt # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/model/EventEntity.kt # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/send/LocalEchoEventFactory.kt # vector/src/main/java/im/vector/app/core/di/FragmentModule.kt # vector/src/main/java/im/vector/app/core/di/ScreenComponent.kt # vector/src/main/java/im/vector/app/features/command/Command.kt # vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailActivity.kt # vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewModel.kt # vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt # vector/src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerViewEvents.kt # vector/src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerViewModel.kt # vector/src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerViewState.kt # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/action/MessageActionsViewModel.kt # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/factory/MessageItemFactory.kt # vector/src/main/java/im/vector/app/features/navigation/DefaultNavigator.kt # vector/src/main/java/im/vector/app/features/navigation/Navigator.kt # vector/src/main/java/im/vector/app/features/notifications/NotificationUtils.kt # vector/src/main/java/im/vector/app/features/permalink/PermalinkHandler.kt # vector/src/main/res/layout/fragment_room_detail.xml

- Disable thread awareness when threads are enabled

# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/relation/RelationService.kt # tools/check/forbidden_strings_in_code.txt # vector/build.gradle # vector/src/main/java/im/vector/app/core/di/FragmentModule.kt # vector/src/main/java/im/vector/app/core/resources/UserPreferencesProvider.kt # vector/src/main/java/im/vector/app/features/command/Command.kt # vector/src/main/java/im/vector/app/features/command/CommandParser.kt # vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewState.kt # vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt # vector/src/main/java/im/vector/app/features/home/room/detail/TimelineViewModel.kt # vector/src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerViewModel.kt # vector/src/main/java/im/vector/app/features/home/room/detail/search/SearchResultItem.kt # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/TimelineEventController.kt # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/factory/MessageItemFactory.kt # vector/src/main/java/im/vector/app/features/navigation/Navigator.kt # vector/src/main/java/im/vector/app/features/notifications/NotificationUtils.kt # vector/src/main/java/im/vector/app/features/settings/VectorPreferences.kt # vector/src/main/res/layout/fragment_timeline.xml # vector/src/main/res/xml/vector_settings_labs.xml

- Update a text resource

bmarty · 2022-01-31T10:07:24Z

.../vector/app/features/home/room/detail/timeline/helper/TimelineControllerInterceptorHelper.kt

-            val indexOfPrefetchForward = DEFAULT_PREFETCH_THRESHOLD.coerceAtMost(size - 1)
+            val indexOfPrefetchForward = DEFAULT_PREFETCH_THRESHOLD
+                    .coerceAtMost(size - 1)
+                    .coerceAtLeast(0)


Just on the form: coerceIn(minimumValue: Int, maximumValue: Int) exists.

Nice, let's use that, thanks!

@bmarty Actually, coerceIn is not exactly the same. So I will revert using coerceIn. When the range is empty or like [0 to -5] coerceIn will not work

bmarty

Thanks for the update!
I added more comments

...-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/threads/ThreadsService.kt

bmarty · 2022-01-31T20:31:41Z

...-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/threads/ThreadsService.kt

+    fun mapEventsWithEdition(threads: List<TimelineEvent>): List<TimelineEvent>
+
+    /**
+     * Marks the current thread as read. This is a local implementation


Why do you mean by This is a local implementation? I think I understand, but for a SDK user who may read this documentation, it will be maybe not clear enough.

bmarty · 2022-01-31T20:42:04Z

vector/src/main/java/im/vector/app/features/command/CommandParser.kt

+            }
+        }
+        return null
+    }


Nit: could be re-write with

private fun getNotSupportedByThreads(isInThreadTimeline: Boolean, slashCommand: String): Command? { return if (isInThreadTimeline) { notSupportedThreadsCommands.firstOrNull { it.command == slashCommand } } else { null } }

bmarty · 2022-01-31T20:47:39Z

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

            is MessageLocationContent            -> {
                handleShowLocationPreview(messageContent, informationData.senderId)
            }
            else                                 -> {
-                Timber.d("No click action defined for this message content")
+                onThreadSummaryClicked(informationData.eventId, isRootThreadEvent)


This change is not ideal (but I know it's due to a recent merge), I would prefer to read:

if (isRootThreadEvent) { onThreadSummaryClicked(informationData.eventId) } else { Timber.d("No click action defined for this message content") }

bmarty · 2022-01-31T20:51:42Z

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

+                if (isRootThreadEvent) {
+                    onThreadSummaryClicked(informationData.eventId, isRootThreadEvent)
+                } else {
+                    timelineViewModel.handle(RoomDetailAction.TapOnFailedToDecrypt(informationData.eventId))


With this change, there is no way to get UISI details if the event is a root thread event. But when we have a UISI, can the app knows that this is a root thread event? If yes, I think we must change that.
CC @BillCarsonFr

No need to investigate that I can remove that to be sure, it will still be clickable the thread summary so we will have both actions :)

bmarty · 2022-01-31T20:52:14Z

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

                    }
                    .show()
        }
    }

+    override fun onThreadSummaryClicked(eventId: String, isRootThreadEvent: Boolean) {


I would remove the second param, since it will always be true at the call sites

Actually when called from within the TimelineFragment it is not always true

Reading it twice I think it will always be true when called from the TimelineFragment

line will be true if this is a root thread event and false if this is a normal message, and will act accordignly

bmarty

Thanks for the update. I will do some test today

bmarty · 2022-02-01T12:28:33Z

...src/main/java/im/vector/app/features/home/room/detail/timeline/factory/MessageItemFactory.kt

@@ -168,6 +171,11 @@ class MessageItemFactory @Inject constructor(
            return noticeItemFactory.create(params)
        }

+        // This is a thread event and we will [debug] display it when we are in the main timeline


I would have move the comment inside the if block.

True, updated

bmarty · 2022-02-01T12:30:41Z

...ava/im/vector/app/features/home/room/detail/timeline/helper/TimelineEventVisibilityHelper.kt

@@ -117,7 +117,7 @@ class TimelineEventVisibilityHelper @Inject constructor(private val userPreferen
            rootThreadEventId: String?
    ): Boolean {
        // If show hidden events is true we should always display something
-        if (userPreferencesProvider.shouldShowHiddenEvents()) {
+        if (userPreferencesProvider.shouldShowHiddenEvents() && !isFromThreadTimeline) {


Does it means that a message edition in a thread will not be displayed as a debug event in the thread? This is fine, just want to confirm. I will do some test when the APK will be ready

Exactly! It will be displayed in the main timeline. We can of course further improve all those things when threads are more stable

bmarty

Quick smoke test and it seems to work fine! Thank!
We can merge if CI is happy.
I will create an issue to test the new screens in the sanity test.

ariskotsomitopoulos added 30 commits October 20, 2021 18:39

Threads init commit

ab87937

Add room avatar to threads activities

cb63766

Make room thread detail text composer visible

a2a2315

Add changelog file

cb0fefa

Reply In Thread, create a new thread timeline

ecc9b59

- Thread Summary along with optimization

8c53942

- Create new thread & reply to thread

Supporting command in threads

4160688

Add Replies support from within a thread

3d93500

Add sending file to thread support

3de0f7b

** Important while this feature depends on local echo, should be added local echo support in threads to work 100%

- Add specific toolbar for threads

586b3d8

- Renamed RoomDetailFragment to TimelineFragment while it should be reused from threads - View root thread message in room functionality

View all threads screen implementation & UI

722f367

Add user friendly message thread summary on the SDK side Fix not encrypted rooms thread summaries

Add date in view all threads

5e5ce61

UI Improvements on threads summary Add View In Room bottom sheet action from within thread timeline root message

Add local filtering in thread list

afc69c7

Handle chunks merging with thread summary

c4967a2

Add animation to fragment transition with offset for recyclerview initialization Support threads on deleted events

Delete root message UI

2a83e93

Permalink handling for thread events

53ca86d

Highlight the whole message along with the thread summary

e7b8b90

Enhance search functionality to support threads

0241d66

Threads notification badge UI

d1bb96c

Implement LOCAL thread notifications that work only on real time.

c40a686

Add/Fix local echo to threads timeline

b1d4031

Disable local echo for normal messages while there is a duplication

57ef0b5

Support stickers in threads

5c015a7

- Enhance local notification to work with read receipt & the latest c…

d56281d

…hunk - Local notification mentioning system - Fix/Improve thread list filtering

Fix threads sort order, newest first

5ceed40

Fix threads sort order, newest first

2aa24f0

Fix stickers in unencrypted rooms

6a33c41

- Fix remaining conflicts with develop

20357ce

- Disable thread awareness when threads are enabled

ariskotsomitopoulos added 6 commits January 27, 2022 17:11

Merge develop into this branch

bac6d27

ktlint format

78dfac5

Further improve thread summary after forward scrolling

1d6d810

- ktlint format

b1067e9

- Update a text resource

Fix IndexOutOfBound crashes while clicking permalinks

cdd36ce

bmarty reviewed Jan 31, 2022

View reviewed changes

ariskotsomitopoulos added 11 commits January 31, 2022 12:19

Improve coerceIn format

32a982c

Revert the use of coerceIn

5ff5f76

Introduce ThreadsService by splitting TimelineService

3253a25

Lazy load notSupportedThreadsCommands to improve performance

cb3501e

Enhance SlashCommandNotSupportedInThreads

d91f3d2

MessageComposerViewModel format

14e56b8

ktlint format

26eaa84

Fix error in unit test

ec9b6aa

Formating & remove unused comments

f07c23f

Merge branch 'develop' into feature/aris/threads

d509b33

Fix conflicts

15fe9ed

bmarty reviewed Jan 31, 2022

View reviewed changes

ariskotsomitopoulos added 2 commits February 1, 2022 12:13

PR remarks

fcc095a

ktlint format

cfa52d8

ariskotsomitopoulos changed the title ~~Threads local implementation~~ Threads P0 Release Feb 1, 2022

Improve hidden events for threads

877c9be

bmarty reviewed Feb 1, 2022

View reviewed changes

Formatting

ed992dd

bmarty approved these changes Feb 1, 2022

View reviewed changes

ariskotsomitopoulos merged commit 3d5f8ed into develop Feb 1, 2022

ariskotsomitopoulos deleted the feature/aris/threads branch February 1, 2022 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Threads P0 Release #4746

Threads P0 Release #4746

ariskotsomitopoulos commented Dec 17, 2021 •

edited

Loading

bmarty Jan 31, 2022 •

edited

Loading

ariskotsomitopoulos Jan 31, 2022

ariskotsomitopoulos Jan 31, 2022

bmarty Feb 1, 2022

bmarty left a comment

bmarty Jan 31, 2022

bmarty Jan 31, 2022

bmarty Jan 31, 2022

bmarty Jan 31, 2022

ariskotsomitopoulos Feb 1, 2022

bmarty Feb 1, 2022

bmarty Jan 31, 2022

ariskotsomitopoulos Feb 1, 2022

bmarty Feb 1, 2022

ariskotsomitopoulos Feb 1, 2022 •

edited

Loading

bmarty left a comment

bmarty Feb 1, 2022

ariskotsomitopoulos Feb 1, 2022

bmarty Feb 1, 2022

ariskotsomitopoulos Feb 1, 2022 •

edited

Loading

bmarty left a comment

Threads P0 Release #4746

Threads P0 Release #4746

Conversation

ariskotsomitopoulos commented Dec 17, 2021 • edited Loading

Local Threads implementation for P0 release

bmarty Jan 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ariskotsomitopoulos Feb 1, 2022 • edited Loading

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ariskotsomitopoulos Feb 1, 2022 • edited Loading

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

ariskotsomitopoulos commented Dec 17, 2021 •

edited

Loading

bmarty Jan 31, 2022 •

edited

Loading

ariskotsomitopoulos Feb 1, 2022 •

edited

Loading

ariskotsomitopoulos Feb 1, 2022 •

edited

Loading