Emojis in emotes causing crashes #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes android 12+ crash when certain emojis are used within the emote content
ariskotsomitopoulos
approved these changes
Dec 16, 2021
bmarty
approved these changes
Dec 16, 2021
| @@ -625,6 +625,7 @@ class MessageItemFactory @Inject constructor( | |||
| message(message) | |||
| } | |||
| } | |||
| .bindingOptions(bindingOptions) | |||
There was a problem hiding this comment.
If only I had checked all the instance of MessageTextItem_() in this class...
Co-authored-by: Benoit Marty <[email protected]>
ganfra
approved these changes
Dec 17, 2021
I'm not 100% as any expoy attribute which can contain an emoji is at risk |
ouchadam
changed the title
ouchadam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4743
A follow up to the original emoji fix #4698, we had a missing case (the emote section eg
/me :tada:)