FTUE Auth - I already have an account #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not super happy~ about having to the copy all of the login fragments, unfortunately there's a lot of inheritance in the area and the fragments are coupled directly to view models would recommend reviewing by commits! |
ouchadam
force-pushed
the
feature/adm/dynamic-login-flow
branch
from
0dc4d38 to
74594d8
Compare
ouchadam
added
the
Z-FTUE
ouchadam
changed the base branch from
feature/adm/dynamic-login-flow
to
feature/adm/cloning-login-domain-to-ftue
ouchadam
force-pushed
the
feature/adm/i-already-have-an-account
branch
from
6846cf2 to
4d02621
Compare
|
closing to extract the fragment copying to its own PR |
ouchadam
changed the base branch from
feature/adm/cloning-login-domain-to-ftue
to
feature/adm/cloning-login-fragments-to-ftue
ouchadam
force-pushed
the
feature/adm/i-already-have-an-account
branch
2 times, most recently
from
854953e to
801a02e
Compare
ouchadam
force-pushed
the
feature/adm/cloning-login-fragments-to-ftue
branch
2 times, most recently
from
9ccad11 to
603c2fa
Compare
- supports switching between a copied legacy flow (DefaultFTUE) and the WIP variant - this will allow us to make iterative changes to the default ftue flow without affecting the legacy flow/forks
…verriding and merge login2 behaviour
… already have an account
- the onboarding uses the icon and it can be displayed for developer mode users
ouchadam
force-pushed
the
feature/adm/i-already-have-an-account
branch
from
801a02e to
6fbf8fa
Compare
Base automatically changed from
feature/adm/cloning-login-fragments-to-ftue
to
develop
January 6, 2022 13:59
ouchadam
commented
Jan 6, 2022
| @@ -36,4 +38,5 @@ interface VectorFeatures { | |||
|
|
|||
| class DefaultVectorFeatures : VectorFeatures { | |||
| override fun onboardingVariant(): VectorFeatures.OnboardingVariant = BuildConfig.ONBOARDING_VARIANT | |||
| override fun isAlreadyHaveAccountSplashEnabled() = true | |||
There was a problem hiding this comment.
the I already have an account is enabled by default when the onboarding variant is set to FTUE_AUTH, it's currently set to LEGACY, will raise a dedicated PR to enable the FTUE_AUTH onboarding as the default variant
bmarty
approved these changes
Jan 6, 2022
| @@ -28,16 +28,25 @@ class DebugFeaturesStateFactory @Inject constructor( | |||
| return FeaturesState(listOf( | |||
| createEnumFeature( | |||
| label = "Onboarding variant", | |||
| selection = debugFeatures.onboardingVariant(), | |||
| override = debugFeatures.onboardingVariant(), | |||
There was a problem hiding this comment.
I am surprised override is not a reserved Kotlin keyword. Maybe a bit confusing to use it anyway.
There was a problem hiding this comment.
yeah I was surprised as well, will prefix the names to avoid confusion with the language keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4382 Part of #4584
I already have an accountbutton and flow behind the FTUE Auth feature flag