Removing notification settings v1 #4627
Conversation
| lowPriorityClickListener { host.listener?.didSelectMenuAction(RoomListQuickActionsSharedAction.LowPriority(roomSummary.roomId)) } | ||
| } | ||
| // Preview, favorite, settings | ||
| bottomSheetRoomPreviewItem { |
There was a problem hiding this comment.
Test state.roomListActionsArgs.mode == RoomListActionsArgs.Mode.FULL should stay
There was a problem hiding this comment.
Ah maybe not, it seems that only FULL is used nowadays.
Maybe cleanup https://github.com/vector-im/element-android/blob/main/vector/src/main/java/im/vector/app/features/home/room/list/actions/RoomListQuickActionsBottomSheet.kt#L50
There was a problem hiding this comment.
the previous condition was
// V2 always shows full details as we no longer display the sheet from RoomProfile > Notifications
val showFull = state.roomListActionsArgs.mode == RoomListActionsArgs.Mode.FULL || isV2now that v2 is always true, do we need the condition (perhaps it was wrong previously 🤔 )
There was a problem hiding this comment.
I do not think it was wrong before, it was OK in v1 mode, but with this PR, RoomListActionsArgs.Mode.NOTIFICATIONS is never used, so maybe just delete RoomListActionsArgs.Mode.
| if (showFull) { | ||
| RoomListQuickActionsSharedAction.Leave(roomSummary.roomId, showIcon = !isV2).toBottomSheetItem(5) | ||
| } | ||
| RoomListQuickActionsSharedAction.Leave(roomSummary.roomId, showIcon = !true).toBottomSheetItem(5) |
There was a problem hiding this comment.
So please also revert this change
There was a problem hiding this comment.
I think more cleanup can be done in the fun RoomListQuickActionsSharedAction.toBottomSheetItem(...), there is some dead code now.
There was a problem hiding this comment.
good catch! removed ab04e40
ouchadam
force-pushed
the
feature/adm/removing-notification-settings-v1
branch
from
ab04e40 to
96295f6
Compare
Removes the notification settings v1 code branches and flag