select answer should be used for outgoing calls. #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/dla/outgoing_pstn_call_fails
...x-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt
Outdated
Show resolved
Hide resolved
SimonBrandner
approved these changes
Dec 3, 2021
ouchadam
reviewed
Dec 3, 2021
| @@ -203,8 +203,10 @@ internal class MxCallImpl( | |||
|
|
|||
| override fun selectAnswer() { | |||
| Timber.tag(loggerTag.value).v("select answer $callId") | |||
| if (isOutgoing) return | |||
| state = CallState.Answering | |||
There was a problem hiding this comment.
do we still set this state somewhere else or does CallState.Answering no longer need to exist?
There was a problem hiding this comment.
I guess the initial issue was due to a quick copy paste of the accept fun (https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt#L179)
ouchadam
approved these changes
Dec 3, 2021
ganfra
approved these changes
Dec 3, 2021
bmarty
approved these changes
Dec 3, 2021
| @@ -203,8 +203,10 @@ internal class MxCallImpl( | |||
|
|
|||
| override fun selectAnswer() { | |||
| Timber.tag(loggerTag.value).v("select answer $callId") | |||
| if (isOutgoing) return | |||
| state = CallState.Answering | |||
There was a problem hiding this comment.
I guess the initial issue was due to a quick copy paste of the accept fun (https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt#L179)
...x-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt
Outdated
Show resolved
Hide resolved
bmarty
reviewed
Dec 3, 2021
...x-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4621
Use case is:
The reason being that if bob tries to accept on two devices, it's clear which one alice is actually trying to connect to.
I believe this problem might have just surfaced recently due to changes at the sip bridge adding a timeout for the
selectAnswer