Workaround to fetch all the pending toDevice events from a Synapse homeserver #4614
Conversation
…meserver - SyncWorker
| automaticallyBackgroundSync(workManagerProvider, params.sessionId, params.timeout, params.delay, forceImmediate = hasToDeviceEvents) | ||
| } else if (hasToDeviceEvents) { | ||
| // Previous response has toDevice events, request an immediate sync request | ||
| requireBackgroundSync(workManagerProvider, params.sessionId, 0) |
There was a problem hiding this comment.
This is not a workaround actually, and we should always do that, even it the bug is fixed on Synapse, WDYT @BillCarsonFr ?
There was a problem hiding this comment.
Yes (workaround is to set timeout to 0, which is probably default here ?)
We should check if we try to redecrypt existing notifications after the catchup sync?
There was a problem hiding this comment.
Ok, thanks.
We should check if we try to redecrypt existing notifications after the catchup sync?
To be honest I did not do any test, I'm just coding it. Not sure how I can reproduce the test conditions
There was a problem hiding this comment.
Just a last comment, I noticed that on iOS when catching up we don't try ti upload new otk or to handle room key request until the catchup sync (to get all to devices) is done https://github.com/matrix-org/matrix-ios-sdk/blob/4e8db1ee5d47e7cb3bcfc4b02508c9f56996fad0/MatrixSDK/Crypto/MXCrypto.m#L931
issue ref: element-hq/element-web#2782
|
It will wait for the next release (1.3.11). |
|
LGTM, @BillCarsonFr can you approve this PR please? |
Fixes #4612