Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robustness when getting data from cursors. #4607

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 1, 2021

Use androidx.core.database extension for better nullability check, and ignore uncomplete data.

Regression from 1.3.7, 1.3.8 not released, so let's merge this PR before release 1.3.9

Fixes #4605

Use androidx.core.database extension for better nullability check, and ignore uncomplete data.
Copy link
Contributor

@Claire1817 Claire1817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK.

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Unit Test Results

  66 files  ±0    66 suites  ±0   47s ⏱️ -1s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 84f7eb2. ± Comparison against base commit 2e52f42.

@bmarty
Copy link
Member Author

bmarty commented Dec 1, 2021

There were 2 observed crashes:

  • Contact with no displayName will not be displayed in the contact list
  • If trying to share such contact (from the timeline) nothing will happen now.

@bmarty bmarty merged commit 9253a36 into develop Dec 1, 2021
@bmarty bmarty deleted the feature/bma/cursor_crash branch December 1, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on Address book [version 1.3.8]
2 participants