Reduced onboarding steps #4590
Closed
Reduced onboarding steps #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- may be temporary whilst evaluating login2
bmarty
reviewed
Nov 30, 2021
| @@ -2509,6 +2509,7 @@ | |||
| <string name="login_splash_text2">Keep conversations private with encryption</string> | |||
| <string name="login_splash_text3">Extend & customise your experience</string> | |||
| <string name="login_splash_submit">Get started</string> | |||
| <string name="login_splash_already_have_account">I already have an account</string> | |||
There was a problem hiding this comment.
Just to complete our IRL discussion, https://github.com/vector-im/element-android/blob/main/vector/src/main/res/values/strings_login_v2.xml exists and so do https://github.com/vector-im/element-android/blob/main/vector/src/main/res/values/strings_login_v2.xml#L27. The resource from this file are not synced with Weblate, so feel free to do whatever you want with it, like removing strings for instance.
|
closing for now, will reopen avoiding modifications to the base login flow |
This was referenced Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4382 Adding sign in to onboarding splash screen
Removes the Sign In/Sign Up step from the onboarding in favour of the
GET STARTEDandI ALREADY HAVE AN ACCOUNTcontrolling the proceeding flowThis may be temporary, currently evaluating using
login2insteadEDIT: chatted with @daniellekirkwood and @amshakal we'll go ahead with this small change as part of the main login flow with
the aim to have this change in users hands in the next release with the large remaining chunk of FTUE work taking place within
Login2