Iterate on user consent dialog for identity server #4587
Conversation
| import org.matrix.android.sdk.api.session.Session | ||
| import org.matrix.android.sdk.api.session.terms.TermsService | ||
|
|
||
| suspend fun Session.fetchIdentityServerWithTerms(userLanguage: String): IdentityServerWithTerms? { |
There was a problem hiding this comment.
💯 for lifting out of the view model
| import im.vector.app.core.platform.VectorViewEvents | ||
| import im.vector.app.features.discovery.IdentityServerWithTerms | ||
|
|
||
| sealed class ContactsBookViewEvents : VectorViewEvents { |
There was a problem hiding this comment.
worlds smallest nit: could be a sealed interface, saves having to write () in the extends 😅
There was a problem hiding this comment.
I think at the beginning of the project sealed interface was not a thing, but now, yes. I prefer to perform a global replace on a dedicated PR
| @@ -40,16 +45,36 @@ fun Context.displayInWebView(url: String) { | |||
| .show() | |||
| } | |||
|
|
|||
| fun Context.showIdentityServerConsentDialog(configuredIdentityServer: String?, policyLinkCallback: () -> Unit, consentCallBack: (() -> Unit)) { | |||
| fun Context.showIdentityServerConsentDialog(identityServerWithTerms: IdentityServerWithTerms?, | |||
There was a problem hiding this comment.
general question about identity servers, are privacy policies enforced?
There was a problem hiding this comment.
You mean can we have an IS without any privacy policy? I do not think so, but the code should be robust to that.
By the way I will create some issues (defect, but no P1) I have seen in the area
|
Just pushed a small commit |
Implements #4577
New dialogs: #4577 (comment)
We need to retrieved the T&C, that's why many changes are necessary. Sadly there is some code duplication between the ViewModels, we may find a way to reduce that later.