Notification images #4430
Merged
Notification images #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llback - simplifies the handling of notifications, will allow us to reduce redundant synchronisations and suspend the entire notification update (will be needed for supporting images)
…a single update point of entry for mutating the events - this avoids multiple synchronisation locks by batching updates and ensures a single notification render pass
…tifiableEventReceived not synchronised for use within the synchronized batching - makes the refresh function private as all interactions now come through via update
- downloads and exports any images whilst resolving the notification event
…ion image, will allow us to continue to show the notifications
…r non image based attachments
bmarty
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature PR containing
#4401 Single notification update point of entry
#4402 Supporting images in notifications
Adds image support to the message notifications
FileProvider Uriin order to allow the notifications to read and display the image