Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force call ringtones to loop #4381

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Force call ringtones to loop #4381

merged 2 commits into from
Nov 2, 2021

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Nov 1, 2021

Fixes #4047

Out of the box android is relying on audio file metadata to determine if the ringtone should loop

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

Unit Test Results

  62 files  ±0    62 suites  ±0   1m 1s ⏱️ +10s
118 tests ±0  118 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
350 runs  ±0  350 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5bda798. ± Comparison against base commit 0d6e8bd.

bmarty
bmarty approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks!

@bmarty bmarty merged commit 23a8ac6 into develop Nov 2, 2021
@bmarty bmarty deleted the feature/adm/looping-call-ringtones branch November 2, 2021 08:59
@opusforlife2
Copy link
Contributor

Thank you, @ouchadam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VoIP] Ring tone plays only once
3 participants
@ouchadam @opusforlife2 @bmarty