Fix permalink handling #4369
Merged
Fix permalink handling #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whole link base url was compared to supported hosts instead of the host part only
bmarty
approved these changes
Oct 29, 2021
| @@ -273,14 +273,13 @@ class HomeActivity : | |||
| val resolvedLink = when { | |||
| // Element custom scheme is not handled by the sdk, convert it to matrix.to link for compatibility | |||
| deepLink.startsWith(MATRIX_TO_CUSTOM_SCHEME_URL_BASE) -> { | |||
| val let = when { | |||
| when { | |||
bmarty
reviewed
Oct 29, 2021
ouchadam
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole link base url (eg.
https://develop.element.io) was compared to the supported hosts list instead of the host part only (develop.element.io), causing the link not handled anymore (displaying a malformed link dialog, which was not true...)