Add API LoginWizard.loginCustom(data: JsonDict): Session
#4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to login to a homeserver using arbitrary request content
ouchadam
reviewed
Oct 26, 2021
| @@ -121,6 +121,10 @@ internal interface AuthAPI { | |||
| @POST(NetworkConstants.URI_API_PREFIX_PATH_R0 + "login") | |||
| suspend fun login(@Body loginParams: TokenLoginParams): Credentials | |||
|
|
|||
| @Headers("CONNECT_TIMEOUT:60000", "READ_TIMEOUT:60000", "WRITE_TIMEOUT:60000") | |||
There was a problem hiding this comment.
are these timeouts different to the http client connection timeouts?
There was a problem hiding this comment.
Yes, I think so, here I've just copy pasted what was above without really thinking about it.
ouchadam
reviewed
Oct 26, 2021
| * Login to the homeserver by sending a custom JsonDict. | ||
| * The data should contain at least one entry "type" with a String value. | ||
| */ | ||
| suspend fun loginCustom(data: JsonDict): Session |
There was a problem hiding this comment.
should we enforce the type as a separate parameter and apply it to the jsonDict, or is the documentation enough?
There was a problem hiding this comment.
I've thought about it, happy to see that you have the same thoughts, but here it will be up to the caller to do what's necessary for this API to work, and I did not want to close doors.
ouchadam
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to login to a homeserver using arbitrary request content
Fixes #4266