Unable to join room by name #4345
Conversation
…t when linking from the public rooms - the activity is still finished causing the popup to not actually display
…vigation, not the bottomsheets - the bottomsheets require the activity to stay around as they host the sheet instance, fixes missing join sheets
| @@ -51,6 +52,7 @@ data class RoomPreviewData( | |||
| get() = MatrixItem.RoomItem(roomId, roomName ?: roomAlias, avatarUrl) | |||
| } | |||
|
|
|||
| @AndroidEntryPoint | |||
There was a problem hiding this comment.
This is out of scope of this PR, but I made a quick check and this annotation is also missing for:
- DebugPermissionActivity
- PinActivity
- SignedOutActivity
- SpacePeopleActivity
- SpacePreviewActivity
I think we can take the opportunity to add it also there. Thanks! CC @ganfra
There was a problem hiding this comment.
There was a problem hiding this comment.
Those Activities should be opened by the allScreensTest(), so maybe we should create a dedicated PR with those change, IDK. But it definitely need to be fixed before Hilt is released to the store, so better to do it ASAP
There was a problem hiding this comment.
agreed we should fix these asap, ideally a separate PR would have been better, at least the change within this PR is quite small
I also double checked the remaining activities and couldn't find any others that were missing the entry point 🤞
Fixes #4255
When joining a room by name a
Can't joinerror is displayed, this was caused by a missingMatrixToBottomSheet.InteractionListenerHowever the current flow was finishing the activity which meant the sheet was never displayed.
The fix was to only trigger the navigation interceptor for the room activity navigation instead of including the bottom sheets. The bottom sheet instances live within the activity.
EntryPoint