Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate App DI framework to Hilt #4312

Merged
merged 16 commits into from
Oct 25, 2021
Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Oct 22, 2021

Fix #3888
See hilt_migration documentation for more detail

@github-actions
Copy link

github-actions bot commented Oct 22, 2021

Unit Test Results

  48 files  ±0    48 suites  ±0   59s ⏱️ +14s
  91 tests ±0    91 ✔️ ±0  0 💤 ±0  0 ±0 
244 runs  ±0  244 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit e1f4e4f. ± Comparison against base commit 0d1382a.

♻️ This comment has been updated with latest results.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thanks.
Looks like the F-Droid variant needs some migration too.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
I will merge it later in the day.

@bmarty bmarty merged commit 3354cd1 into develop Oct 25, 2021
@bmarty bmarty deleted the feature/fga/hilt_app_migration branch October 25, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Hilt
2 participants