Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant text in feature request issue form #4257

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Remove redundant text in feature request issue form #4257

merged 3 commits into from
Nov 16, 2021

Conversation

opusforlife2
Copy link
Contributor

@opusforlife2 opusforlife2 commented Oct 15, 2021

Pull Request Checklist

This is a similar PR to #4076. It removes a redundant sentence.

Copy link
Contributor Author

@opusforlife2 opusforlife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the self review. I really don't get the point of this.

@opusforlife2
Copy link
Contributor Author

@kittykat Please review.

@bmarty bmarty requested a review from kittykat October 18, 2021 12:41
.github/ISSUE_TEMPLATE/enhancement.yml Outdated Show resolved Hide resolved
@kittykat
Copy link
Contributor

@opusforlife2 could you please add a signoff before we merge this? (git commit --amend --signoff and force push to your branch)

@bmarty
Copy link
Member

bmarty commented Nov 15, 2021

Here's the self review. I really don't get the point of this.

A self review is basically open https://github.com/vector-im/element-android/pull/4257/files and check that everything looks fine. (Stupid) mistakes can then be fixed by the submitter before requesting a review from someone else.

@opusforlife2
Copy link
Contributor Author

@kittykat I read the contributing guide before opening my first PR, which says that you require legal names, and anonymous contributions aren't allowed, but I saw several merged PRs which didn't have a sign off, so I assumed that for minor changes, this isn't much of an issue.

If this is a blocker then please let me know, because I wish to stay anonymous (hence no sign offs).

(Also, I only use Github's web interface to create PRs, and I don't know if it lets you sign off on PRs, anyway.)

@kittykat
Copy link
Contributor

kittykat commented Nov 15, 2021

@kittykat I read the contributing guide before opening my first PR, which says that you require legal names, and anonymous contributions aren't allowed, but I saw several merged PRs which didn't have a sign off, so I assumed that for minor changes, this isn't much of an issue.

If this is a blocker then please let me know, because I wish to stay anonymous (hence no sign offs).

That's completely understandable. I will double check on policy and get back to you.

(Also, I only use Github's web interface to create PRs, and I don't know if it lets you sign off on PRs, anyway.)

(Technically you'd just need to add a line to your PR/commits which says "Signed-off-by: name <email>")

@opusforlife2
Copy link
Contributor Author

Oh, so "Signed off by: opusforlife2" is fine?

@bmarty
Copy link
Member

bmarty commented Nov 15, 2021

but I saw several merged PRs which didn't have a sign off

If the PR is not coming by someone from the Element team this is not normal. Do you have an example in mind?

And yes, I assume that #4257 (comment) is enough.

@opusforlife2
Copy link
Contributor Author

Ohkay. If they're exempt, then it is likely I saw some team member PRs and made an incorrect assumption. Sorry for the confusion.

And yes, I assume that #4257 (comment) is enough.

Ummm. Can I sign off on future commits? I can't edit existing commits on Github.

@bmarty bmarty merged commit 10ec6e7 into element-hq:develop Nov 16, 2021
@opusforlife2 opusforlife2 deleted the FR_template branch November 17, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants