-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant text in feature request issue form #4257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the self review. I really don't get the point of this.
@kittykat Please review. |
@opusforlife2 could you please add a signoff before we merge this? ( |
A self review is basically open https://github.com/vector-im/element-android/pull/4257/files and check that everything looks fine. (Stupid) mistakes can then be fixed by the submitter before requesting a review from someone else. |
@kittykat I read the contributing guide before opening my first PR, which says that you require legal names, and anonymous contributions aren't allowed, but I saw several merged PRs which didn't have a sign off, so I assumed that for minor changes, this isn't much of an issue. If this is a blocker then please let me know, because I wish to stay anonymous (hence no sign offs). (Also, I only use Github's web interface to create PRs, and I don't know if it lets you sign off on PRs, anyway.) |
That's completely understandable. I will double check on policy and get back to you.
(Technically you'd just need to add a line to your PR/commits which says " |
Oh, so "Signed off by: opusforlife2" is fine? |
If the PR is not coming by someone from the Element team this is not normal. Do you have an example in mind? And yes, I assume that #4257 (comment) is enough. |
Ohkay. If they're exempt, then it is likely I saw some team member PRs and made an incorrect assumption. Sorry for the confusion.
Ummm. Can I sign off on future commits? I can't edit existing commits on Github. |
Pull Request Checklist
This is a similar PR to #4076. It removes a redundant sentence.