Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a paragraph about Open source #4231

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add a paragraph about Open source #4231

merged 1 commit into from
Oct 13, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 12, 2021

To be approved

@github-actions
Copy link

Unit Test Results

  44 files  ±0    44 suites  ±0   53s ⏱️ +3s
  87 tests ±0    87 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
228 runs  ±0  228 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d4f6290. ± Comparison against base commit 37dbaad.

ouchadam
ouchadam approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for us to approve or marketing ?

@bmarty
Copy link
Member Author

bmarty commented Oct 13, 2021

Marketing, sorry I was not clear. I've asked for a review internally.

@bmarty
Copy link
Member Author

bmarty commented Oct 13, 2021

Approved by sirloynes

@bmarty bmarty marked this pull request as ready for review October 13, 2021 09:11
@bmarty bmarty merged commit 9661fa0 into develop Oct 13, 2021
@bmarty bmarty deleted the feature/bma/store_desc branch October 13, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouchadam ouchadam ouchadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @ouchadam