Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash to render failed message warning stub #4105

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Fix crash to render failed message warning stub #4105

merged 2 commits into from
Sep 29, 2021

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Sep 28, 2021 •
edited
Loading

Fixes #4110

@onurays onurays requested a review from ganfra September 28, 2021 17:44
@github-actions
Copy link

github-actions bot commented Sep 28, 2021 •
edited
Loading

Unit Test Results

  38 files  ±0    38 suites  ±0   46s ⏱️ ±0s
  77 tests ±0    77 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
196 runs  ±0  196 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 254e849. ± Comparison against base commit 254e849.

♻️ This comment has been updated with latest results.

@ganfra
Copy link
Member

ganfra commented Sep 29, 2021

Fixes #3833

I don't see how it's fixing 3833?
Your PR is fixing a crash introduced after the issue was created

ganfra
ganfra requested changes Sep 29, 2021
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my remarks

vector/src/main/res/layout/fragment_room_detail.xml
@@ -98,7 +98,7 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
app:barrierDirection="top"
app:constraint_referenced_ids="composerLayout,notificationAreaView,failedMessagesWarningView" />
app:constraint_referenced_ids="composerLayout,notificationAreaView,failedMessagesWarningStub" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other Barrier needs to update too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already failedMessagesWarningStub, do you confirm it's wrong?
https://github.com/vector-im/element-android/blob/develop/vector/src/main/res/layout/fragment_room_detail.xml#L207

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is... wrong?

bmarty
bmarty requested changes Sep 29, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, crash reproduced and fix tested OK, but the changelog file is not correct.

Can you update it please?
It should be file 4105.bugfix with content "Fix a crash (regression in 1.3.0) in the timeline when a message has failed to be sent"

changelog.d/3833.bugfix Outdated
@@ -0,0 +1 @@
[Bug|Crash] Voice Messages sending need more robustfully
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really related to voice message, and/or issue 3833.

@bmarty bmarty merged commit 254e849 into develop Sep 29, 2021
@bmarty bmarty deleted the feature/ons/fix_failed_message_crash branch September 29, 2021 09:54
@bmarty bmarty mentioned this pull request Sep 29, 2021
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra requested changes

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash while rendering failed message warning
3 participants
@onurays @ganfra @bmarty