Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android Auto notification support #4078

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Add Android Auto notification support #4078

merged 1 commit into from
Sep 30, 2021

Conversation

abaker
Copy link
Contributor

@abaker abaker commented Sep 24, 2021

Pull Request Checklist

@abaker
Copy link
Contributor Author

abaker commented Sep 24, 2021

This PR is for #240. It enables message notifications in Android Auto with mark as read and voice reply functionality.

In order to release this to the Play Store you have to click on Advanced settings > Release types > Add release type > Android Auto > Accept the Android for Cars Terms of Service

It seems like apps require some sort of entitlement granted by the Play Store to actually work on the Android Auto app or an Android Auto head unit. Debug builds will only work in the Desktop Head Unit. I assume this also means the F-Droid build will not work with Android Auto.

@ouchadam ouchadam self-requested a review September 30, 2021 08:42
Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 thanks for this!

  • double checked notification actions still work

@bmarty bmarty merged commit 5d51431 into element-hq:develop Sep 30, 2021
@github-actions
Copy link

Unit Test Results

  42 files  ±0    42 suites  ±0   46s ⏱️ ±0s
  83 tests ±0    83 ✔️ ±0  0 💤 ±0  0 ±0 
220 runs  ±0  220 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5d51431. ± Comparison against base commit 5d51431.

@bmarty
Copy link
Member

bmarty commented Sep 30, 2021

Thanks for the PR!

In order to release this to the Play Store you have to click on Advanced settings > Release types > Add release type > Android Auto > Accept the Android for Cars Terms of Service

Taking care of this part with the legals

@abaker abaker deleted the android_auto branch September 30, 2021 18:00
@bmarty
Copy link
Member

bmarty commented Oct 1, 2021

T&C have been accepted:

image

Next step is to upload an APK, which will be done on the next release.

@bmarty bmarty mentioned this pull request Oct 4, 2021
@th0mcat
Copy link
Contributor

th0mcat commented Oct 5, 2021

This PR is for #240. It enables message notifications in Android Auto with mark as read and voice reply functionality.

In order to release this to the Play Store you have to click on Advanced settings > Release types > Add release type > Android Auto > Accept the Android for Cars Terms of Service

It seems like apps require some sort of entitlement granted by the Play Store to actually work on the Android Auto app or an Android Auto head unit. Debug builds will only work in the Desktop Head Unit. I assume this also means the F-Droid build will not work with Android Auto.

Just an FYI for anyone reading this PR: Here's how you can get Android Auto working on a dbg build:

· Enable Developer Mode in the Android Auto app. Settings > Tap the "Version and permission info tab" until Developer Mode is enabled.
· Allow Unknown sources. Setings > 3 button menu > Developer settings > Check "Unknown sources".

image

@bmarty bmarty added this to the Sprint - Element 1.3.2 milestone Oct 8, 2021
@bmarty
Copy link
Member

bmarty commented Oct 8, 2021

After APK 1.3.2 upload:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants