-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bluetooth permissions to work with Android 12 and other small fixes #3901
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2873,7 +2873,7 @@ | |
<string name="upgrade_room_no_power_to_manage">K aktualizaci místnosti potřebujete oprávnění</string> | ||
<string name="upgrade_room_update_parent_space">Automaticky aktualizovat mateřský prostor</string> | ||
<string name="upgrade_room_auto_invite">Automaticky pozvat uživatele</string> | ||
<string name="upgrade_public_room_from_to">Budete aktualizovat tuto místnost z %s na %s.</string> | ||
<string name="upgrade_public_room_from_to">Budete aktualizovat tuto místnost z %1$s na %2$s.</string> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Generally we do not update translations directly in the code. It has to be done in Weblate. Else there is a risk of git conflict that can be a pain to fix. Is it possible for you to revert the change here and do the change on Weblate? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm taking care of that right now. |
||
<string name="upgrade_room_warning">Aktualizace místnosti je pokročilá akce a obvykle se doporučuje tehdy, je-li místnost nestabilní kvůli chybám, chybějícím funkcím nebo slabým místům v zabezpečení. | ||
\nObvykle má vliv pouze na to, jak server místnost zpracovává.</string> | ||
<string name="upgrade_private_room">Aktualizovat soukromou místnost</string> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3470,7 +3470,7 @@ | |
<string name="upgrade_public_room">Upgrade public room</string> | ||
<string name="upgrade_private_room">Upgrade private room</string> | ||
<string name="upgrade_room_warning">Upgrading a room is an advanced action and is usually recommended when a room is unstable due to bugs, missing features or security vulnerabilities.\nThis usually only affects how the room is processed on the server.</string> | ||
<string name="upgrade_public_room_from_to">You\'ll upgrade this room from %s to %s.</string> | ||
<string name="upgrade_public_room_from_to">You\'ll upgrade this room from %1$s to %2$s.</string> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change can be kept, as it is the original string. |
||
<string name="upgrade_room_auto_invite">Automatically invite users</string> | ||
<string name="upgrade_room_update_parent_space">Automatically update space parent</string> | ||
<string name="upgrade_room_no_power_to_manage">You need permission to upgrade a room</string> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per https://developer.android.com/about/versions/12/features/bluetooth-permissions :
"Your app must target Android 12 to declare these permissions". This is not the case, so I think it's more a false positive from lint... And I do not want to introduce regression due to lint. Have you check that everything is fine with this code on a device with Android 10 for instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that the CI is now happy without this fix (see #3954), so I guess we will do this change when we will target Android 12, i.e. API 31)