Show low priority rooms in dm #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
commented
Jul 19, 2021
| updatableQuery = it | ||
| } | ||
| ).buildSections(initialState.displayMode) | ||
| private val roomListSectionBuilder = if (appStateHandler.getCurrentRoomGroupingMethod() is RoomGroupingMethod.BySpace) { |
There was a problem hiding this comment.
no more lazy {} block here, is it OK @BillCarsonFr ?
There was a problem hiding this comment.
I wanted to avoid setting that up in the viewModel init, I think it's better to avoid doing work in constructor. Can it stay lazy?
There was a problem hiding this comment.
OK, but we are just calling the constructor. buildSections() is still called in the lazy {} block. So I think it is OK. Do you agree?
bmarty
commented
Jul 19, 2021
| ONLY_DM, | ||
| ONLY_ROOMS, | ||
| ALL | ||
| } |
There was a problem hiding this comment.
Oh strange, was extracted to a top level class but this did stay...
BillCarsonFr
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3463:
Also some cleanup, I hope I did not break anything. Can you check @BillCarsonFr ?