Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fga/voip asserted identity #3452

Merged
merged 5 commits into from
Jun 11, 2021
Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jun 2, 2021

Handles #3451

Adds support for receiving MSC3086 Asserted Identity events & emitting event from the call object.
Behavior disabled by default in gradle.

@ganfra ganfra requested a review from bmarty June 2, 2021 14:47
@ganfra ganfra force-pushed the feature/fga/voip_asserted_identity branch from cf2b352 to a421f37 Compare June 3, 2021 17:52
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, static review
Can you merge develop or rebase your branch please?

@@ -37,23 +37,26 @@
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent" />

<FrameLayout
<androidx.cardview.widget.CardView
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use MaterialCardView. Also you should merge or rebase to develop

@bmarty bmarty merged commit 75ee5d3 into develop Jun 11, 2021
@bmarty bmarty deleted the feature/fga/voip_asserted_identity branch June 11, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants