Migration to coroutines #3445
Merged
Migration to coroutines #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @Dominaezzz if you want to have a look :) |
Dominaezzz
reviewed
Jun 1, 2021
| @@ -44,35 +43,33 @@ internal class DefaultTypingService @AssistedInject constructor( | |||
| fun create(roomId: String): DefaultTypingService | |||
| } | |||
|
|
|||
| private var currentTask: Cancelable? = null | |||
| private var currentAutoStopTask: Cancelable? = null | |||
| private var job = Job() | |||
There was a problem hiding this comment.
I think this should be a CoroutineScope instead of Job.
There was a problem hiding this comment.
So you would replace private var job = Job() by private var coroutineScope = CoroutineScope(Job()) ?
There was a problem hiding this comment.
private var coroutineScope = CoroutineScope()
Job is added by default.
There was a problem hiding this comment.
The constructor of CoroutineScope requires a context
There was a problem hiding this comment.
Hmm, maybe I'm using a different version.
Well, it's the same either way.
ganfra
approved these changes
Jun 3, 2021
bmarty
force-pushed
the
feature/bma/withContext
branch
from
949818c to
f7f4ec3
Compare
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2449: migrate DefaultTypingService, KeysImporter and KeysExporter to coroutines