Convert MembershipService to suspend functions #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
requested changes
Mar 29, 2021
| @@ -1088,11 +1088,15 @@ class RoomDetailViewModel @AssistedInject constructor( | |||
| } | |||
|
|
|||
| private fun handleRejectInvite() { | |||
| room.leave(null, NoOpMatrixCallback()) | |||
| viewModelScope.launch { | |||
| room.leave(null) | |||
| } | ||
|
|
||
| private fun handleAcceptInvite() { | ||
| room.join(callback = NoOpMatrixCallback()) | ||
| viewModelScope.launch { | ||
| room.join() |
Signed-off-by: Dominic Fischer <[email protected]>
Dominaezzz
force-pushed
the
suspend_functions_10
branch
from
a729bac to
bc68075
Compare
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dominic Fischer [email protected]
Pull Request Checklist