Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert SharedSecretStorageService and AccountDataService to suspend functions #3079

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Convert SharedSecretStorageService and AccountDataService to suspend functions #3079

merged 4 commits into from
Mar 31, 2021

Conversation

Dominaezzz
Copy link
Contributor

Pull Request Checklist

  • Changes has been tested on an Android device or Android emulator with API 21
  • UI change has been tested on both light and dark themes
  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off

bmarty
bmarty reviewed Mar 30, 2021
View reviewed changes
vector/src/main/java/im/vector/app/features/crypto/quads/SharedSecureStorageViewModel.kt Outdated
is SharedSecureStorageAction.SubmitKey -> handleSubmitKey(action)
SharedSecureStorageAction.Back -> handleBack()
SharedSecureStorageAction.ForgotResetAll -> handleResetAll()
SharedSecureStorageAction.DoResetAll -> handleDoResetAll()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the formatting change please?

bmarty
bmarty requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this work! Just one remark about formatting.

@Dominaezzz
Formatting
145c9d2 
Signed-off-by: Dominic Fischer <[email protected]>
bmarty
bmarty approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 79bee63 into element-hq:develop Mar 31, 2021
@bmarty bmarty mentioned this pull request Mar 31, 2021
Open
53 tasks
@Dominaezzz Dominaezzz deleted the suspend_functions_9 branch March 31, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dominaezzz @bmarty