Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert PushersService to suspend functions #3077

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Convert PushersService to suspend functions #3077

merged 3 commits into from
Mar 31, 2021

Conversation

Dominaezzz
Copy link
Contributor

Signed-off-by: Dominic Fischer [email protected]

Pull Request Checklist

  • Changes has been tested on an Android device or Android emulator with API 21
  • UI change has been tested on both light and dark themes
  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off

bmarty
bmarty approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is perfect, thanks!

@bmarty bmarty mentioned this pull request Mar 29, 2021
Open
53 tasks
@bmarty
Copy link
Member

bmarty commented Mar 29, 2021

Sorry, actually the CI is not happy :/

bmarty
bmarty requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check what the CI is reporting please?

@Dominaezzz
Missing file
1e58767 
Signed-off-by: Dominic Fischer <[email protected]>
@Dominaezzz
Copy link
Contributor Author

Any idea why there's no auto-complete in this file im.vector.app.gplay.features.settings.troubleshoot.TestPushFromPushGateway?

@bmarty
Copy link
Member

bmarty commented Mar 30, 2021

Any idea why there's no auto-complete in this file im.vector.app.gplay.features.settings.troubleshoot.TestPushFromPushGateway?

This file is compiled only if you select one of the gplay build variants. You are probably compiling the variant fdroidDebug. In this case, no completion and no live compilation are available. If you select gplayDebug and sync the IDE it will fix that.

@Dominaezzz
Missing file
6226938 
Signed-off-by: Dominic Fischer <[email protected]>
@bmarty
Copy link
Member

bmarty commented Mar 31, 2021

Thanks for the update, I'll fix the ktlint issue on develop

@bmarty bmarty merged commit f2f735a into element-hq:develop Mar 31, 2021
@bmarty
Copy link
Member

bmarty commented Mar 31, 2021

Cleanup in e4e13aa

@Dominaezzz Dominaezzz deleted the suspend_functions_8 branch March 31, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dominaezzz @bmarty