Unifiedpush-OLD

[p1gp1g]

Pull Request Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Pull request is based on the develop branch
• Pull request updates CHANGES.md
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off

It still need some improvement, and help is welcomed.

• Test the gateway and use the user's one if present.¹
• Simplify diff Fdroid/Gplay.²
• Maybe some improvement on the checking list.

¹ im.vector.app.core.pushers.UPHelper.customOrDefaultGateway: GET custom, if it returns '{"gateway":"matrix"} use custom. What is the best way to do the GET on element-android point of view?
² the only diff should be im.vector.app.push.fcm.FCMHelper.isPlayServicesAvailable and im.vector.app.push.fcm.EmbeddedDistrib. And so, the fallback should work on all flavours without a distributor (on Gplay version, it happens only if the gplay version has been installed on a phone without GServices).

[p1gp1g]

At this moment, the FCM gateway used for the embedded fcm distributor is https://matrix.org/_matrix/push/v1/notify. It would need to work as a gateway for unifiedpush (https://unifiedpush.org/developers/embedded_fcm/) (see https://github.com/vector-im/element-android/pull/2993/files#diff-681374630b8521a655056eecffcdf2b05b6ae12e04c6fb4f08a206b3dd19e983R27)

Also, the default endpoint can be changed if you prefer to host it (https://github.com/vector-im/element-android/pull/2993/files#diff-63b96f47c62869ba88e77317ff6a0b31483a6ebee57f5669c8be0c0eefce5c4aR19)

[p1gp1g]

AlertDialogs are forbidden ?

Search for forbidden patterns in code...
❌ Error: 'android\.app\.AlertDialog' detected 1 time, in file './vector/src/main/java/im/vector/app/core/pushers/UPHelper.kt', at line 18.
Rule: Use AlertDialog form v7 compat lib
1 forbidden pattern detected

[ShadowJonathan]

AlertDialogs are forbidden ?

They're not forbidden, you need to use a compatibility library instead of instantiating them directly via that class path

[p1gp1g]

The build doesn't work after the ktlint clean. It shouldn't be related to this PR, since I haven't touch the lib not found :
Could not find org.matrix.gitlab.matrix-org:olm:3.2.2. which is here : https://jitpack.io/org/matrix/gitlab/matrix-org/olm/3.2.2/olm-3.2.2.pom