Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces support - beta #2840

Merged
merged 98 commits into from
Apr 29, 2021
Merged

Spaces support - beta #2840

merged 98 commits into from
Apr 29, 2021

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Feb 18, 2021

Join beta here : https://appdistribution.firebase.dev/i/10ee8a3487126561

See PRs:

#2920
#2930
#3002
#3023
#3030
#3032
#3050
#3160
#3191
#3225

Update: Spaces are no more under lab flag
image

image

image

image

Fixes #2495

Base SDK changes for Spaces support.
This PR adds the fundation for the spaces feature, and will be iterated on, so expect several branches on top of this one with changes/refactoring
Preview / peeking models are subject to changes

  • New Space feature support can be enabled via labs settings
  • Adds the main API entry point for Spaces support
  • Introduces Room types
  • Basic support for switching space / filtering UI
  • basic UI preview based on new server API (only on dendrite for now) that will falback to peeking

image

image

image

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/spaces_sdk branch 6 times, most recently from f5634ba to f1e05b3 Compare February 23, 2021 13:27
@BillCarsonFr BillCarsonFr requested review from bmarty and ganfra and removed request for bmarty February 26, 2021 08:15
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/spaces_sdk branch 6 times, most recently from 5696d49 to 1011606 Compare March 18, 2021 14:25
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/spaces_sdk branch 4 times, most recently from 62de25e to 25c0e54 Compare March 26, 2021 09:57
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remark / question, also I have pushed some commits

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/spaces_sdk branch from bd42670 to 7f50f10 Compare April 2, 2021 08:59
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/spaces_sdk branch 5 times, most recently from b79e36a to fbec250 Compare April 16, 2021 15:01
@BillCarsonFr BillCarsonFr changed the title Feature/bca/spaces sdk Spaces support - beta Apr 19, 2021
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/spaces_sdk branch from dcd673a to 9e7bf3c Compare April 21, 2021 07:44
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/spaces_sdk branch from 7030962 to 70476b9 Compare April 28, 2021 09:16
@bmarty bmarty merged commit 751efb5 into develop Apr 29, 2021
@bmarty bmarty deleted the feature/bca/spaces_sdk branch April 29, 2021 08:18
@razzeee
Copy link

razzeee commented Apr 29, 2021

Downloaded the test build from firebase and installed it, but can't find any mention of spaces or settings. Is there anything else I need to do? I assumed the normal matrix.org instance would work?

@BillCarsonFr
Copy link
Member Author

Downloaded the test build from firebase and installed it, but can't find any mention of spaces or settings. Is there anything else I need to do? I assumed the normal matrix.org instance would work?

There is a currently a bug, I will update today.
Do you have existing space (if not create a first one from web) and eventually clear cache

@razzeee
Copy link

razzeee commented Apr 29, 2021

Thank you, I've added some spaces via https://develop.element.io and it seems to work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spaces] / Read Only MVP Phase 1
4 participants