Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirection #2836

Merged
merged 9 commits into from
Feb 19, 2021
Merged

Fix redirection #2836

merged 9 commits into from
Feb 19, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 17, 2021

Migrate AuthenticationService to suspendable fun (part of #2449)

Ensure homeserver API URL returned with credential is valid, else ignore it (Fixes #2822)

@bmarty
Copy link
Member Author

bmarty commented Feb 17, 2021

@Dominaezzz you may be interested (or we may be interested :) ) to have a look on 6aa5dc9

@Dominaezzz
Copy link
Contributor

It LGTM! 👍

@bmarty bmarty requested a review from BillCarsonFr February 19, 2021 12:51
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit e12cbf9 into develop Feb 19, 2021
@bmarty bmarty deleted the feature/bma/fix_redirection branch February 19, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log-in syncing never completes.
3 participants