Feature/fga/fix some voip issues #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
bmarty
reviewed
Feb 16, 2021
| * As long as the request succeed, it'll check only once by session. | ||
| */ | ||
| @SessionScope | ||
| class PSTNProtocolChecker @Inject internal constructor(private val taskExecutor: TaskExecutor, |
There was a problem hiding this comment.
no interface to hide implementation?
There was a problem hiding this comment.
Yes I can, but I try to remove interfaces when it's not really necessary as we already have a lots... Fields are private and constructor is internal
There was a problem hiding this comment.
Yes, I'd seen the internal constructor. OK, thanks!
|
|
||
| private var alreadyChecked = AtomicBoolean(false) | ||
|
|
||
| private val pstnSupportListeners = emptyList<Listener>().toMutableList() |
| @EpoxyModelClass(layout = R.layout.item_empty) | ||
| abstract class EmptyItem : VectorEpoxyModel<EmptyItem.Holder>() { | ||
| class Holder : VectorEpoxyHolder() | ||
| interface IsEventItem { |
There was a problem hiding this comment.
What do you mean by IsEventItem?
There was a problem hiding this comment.
It's an item which holds one or several event ids. If you have a better name suggestion, because I wasn't inspired...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the crash on the timeline related to hidden tiles.
It also moves the PSTNProtocolCheck on the SDK side as it's bound to the current session.