Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Loudspeaker is always used #2014

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Fix: Loudspeaker is always used #2014

merged 2 commits into from
Sep 1, 2020

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Aug 27, 2020

Fixes #1685

@onurays onurays requested review from bmarty and BillCarsonFr August 27, 2020 13:45
bmarty
bmarty reviewed Aug 28, 2020
View reviewed changes
vector/src/main/java/im/vector/app/features/call/CallAudioManager.kt
@@ -246,7 +246,7 @@ class CallAudioManager(
}

private fun isHeadsetOn(): Boolean {
return isWiredHeadsetOn() || isBluetoothHeadsetOn()
return isWiredHeadsetOn() || (audioManager?.let { isBluetoothHeadsetConnected(it) } ?: false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audioManager should only be used from a single thread, according to Valere's comment.
The fix LGTM, but let discuss with Valere about it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to read state

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bmarty bmarty merged commit 8157644 into develop Sep 1, 2020
@bmarty bmarty deleted the feature/fix_call_sound_device branch September 1, 2020 13:33
@ouchadam ouchadam mentioned this pull request Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty left review comments

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loudspeaker is always used
3 participants
@onurays @bmarty @BillCarsonFr