Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/markdown parsing #2002

Merged
merged 5 commits into from
Sep 1, 2020
Merged

Bugfix/markdown parsing #2002

merged 5 commits into from
Sep 1, 2020

Conversation

MexHigh
Copy link
Contributor

@MexHigh MexHigh commented Aug 25, 2020 •
edited
Loading

This fixes the problem that markdown isn't correctly parsed when the message is composed in the app.
Fixes #1982, Fixes #1939

Pull Request Checklist

  • Changes has been tested on an Android device or Android emulator with API 21
  • UI change has been tested on both light and dark themes
  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off

@absorber
Copy link

Should also fix #1939 if I'm not mistaken.

@MexHigh
Copy link
Contributor Author

MexHigh commented Aug 28, 2020

It does. Thank you.

@bmarty bmarty merged commit 29123ac into element-hq:develop Sep 1, 2020
@bmarty
Copy link
Member

bmarty commented Sep 1, 2020

Thanks for the update

@tulir
Copy link
Contributor

tulir commented Sep 1, 2020 •
edited
Loading

This did not fix #350 nor #1375

Element Android G-b12 (new buildkite):
image

Expected result from Element Web:
image

I don't think it fixed #1939 either, but not completely sure about that

@bmarty bmarty mentioned this pull request Sep 1, 2020
Merged
bmarty added a commit that referenced this pull request Sep 2, 2020
@bmarty
Revert some change from #2002
d0532bb
@bmarty
Copy link
Member

bmarty commented Sep 2, 2020

I reopen the issues, which will be closed once when we can confirm that we do not reproduce them

@bmarty bmarty mentioned this pull request Sep 2, 2020
Closed
@MexHigh MexHigh deleted the bugfix/markdown-parsing branch September 2, 2020 18:41
@MexHigh
Copy link
Contributor Author

MexHigh commented Sep 2, 2020

This did not fix #350 nor #1375

You're right, I read through the issues again and noticed that there were about a different problem. But it does fix #1939.

bmarty added a commit that referenced this pull request Sep 3, 2020
@bmarty
Merge pull request #2043 from vector-im/feature/cleanup_after_2002
d2d372d 
Cleanup after #2002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown Not Rendering Editing message forgets line breaks and markdown
4 participants
@MexHigh @absorber @bmarty @tulir